Bug #885

PlayerPlayer map_action awards dont get added to hlstats_Events_PlayerPlayerActions

Added by Thor over 2 years ago. Updated over 2 years ago.

Status:UserFeedback Start date:12/04/2009
Priority:Normal Due date:
Assignee:psychonic % Done:

0%

Category:Daemon
Target version:1.7.0
Affected Version: Blocking Target Version:

Description

If you create a custom map specific PlayerPlayer action award, it gets added to the hlatsts_Actions table but not hlstats_Events_PlayerPlayerActions. If you look on the web front end, you will see the map specific action, however when you click on it you get no player or victim information.

I have created a temporary solution, however i am unsure if it affects the stats in an unintended way.

See Lines 1396, 1488-1578

HLstats_EventHandlers.plib (102.7 kB) Thor, 12/04/2009 08:31 am

HLstats_EventHandlers.plib (103.1 kB) Thor, 12/17/2009 07:03 am

HLstats_EventHandlers.plib - Fixed actions being counted twice in hlstasts_Actions (104 kB) Thor, 12/24/2009 06:35 am

History

#1 Updated by Thor over 2 years ago

Thor R wrote:

If you create a custom map specific PlayerPlayer action award, it gets added to the hlatsts_Actions table but not hlstats_Events_PlayerPlayerActions. If you look on the web front end, you will see the map specific action, however when you click on it you get no player or victim information.

I have created a temporary solution, however i am unsure if it affects the stats in an unintended way.

See Lines 1396, 1488-1578

Put the wrong version, this is from version 1.6.2

#2 Updated by Packhead over 2 years ago

  • Target version deleted (1.6.3)

Actually target version is not to be used when submitting an issue -- developers will set this as the issue gets assigned to release versions (where it will be fixed or added).

See: http://forums.interwavestudios.com/topic/933-bug-and-feature-tracker-info/

Thanks for the submission.

#3 Updated by psychonic over 2 years ago

  • Status changed from New to UserFeedback
  • Assignee set to psychonic
  • Target version set to 1.6.3

I believe this is a duplicate of #883.

#4 Updated by Thor over 2 years ago

Nicholas Hastings wrote:

I believe this is a duplicate of #883.

Issue #883, was in reference to the general PlyrPlyrActions, i have checked out the latest revision, and this has been fixed, however #885 was in reference to MAP specific PlyrPlyrActions. As stated in the Admin CP :

You can make an action map-specific by prepending the map name and an underscore to the Action Code. For example, if the map "rock2" has an action "goalitem" then you can either make the action code just "goalitem" (in which case it will match all maps) or you can make it "rock2_goalitem" to match only on the "rock2" map.

When you do this, the actions get logged, however the points additions do not happen, and for example ( TF2 related ), a "ctf_2fort_jarate" PlyrPlyr Action, if you go to " hlstats.php?mode=actioninfo&action=ctf_2fort_jarate&game=tf " There is no Action Details, as well as Victims of 2Fort Jarate...

Perhaps, this functionality is not intended, or i have been doing something wrong, however it makes sense that this information should be available, and the points addition should happen...

#5 Updated by Packhead over 2 years ago

  • Target version changed from 1.6.3 to 1.6.5

This needs to be discussed further and won't make it in to 1.6.3.

#6 Updated by Packhead over 2 years ago

  • Target version changed from 1.6.5 to 1.7.0

This is kind of a mix between a bug and a feature. We're discussing this internally how to accommodate this feature. The remainder of the 1.6 branch is for bug fixes only, so I'm going to push this to 1.7.

Don't think we're just pushing the issue back and back, we've had a few sketchy releases and we're trying to get a good stable one. We'll definitely be talking about this item, though.

#7 Updated by Thor over 2 years ago

Thanks for the update, if someone would not mind looking over the fix i have made for this, i would appreaciate it. I have reviewed the code a few times, and i am fairly certain that the fix i did shold not have any unintended circumstances, however i am new to perl coding, and you all are the experts =) If somebody could point out if i am breaking the stats by using my fix. Perhaps i did not outline the "bug/feature" problem correctly... I am just curious as to whether or not i am breaking something by using the changes i have made to the HLstats_EventHandlers.plib file.

Line 1406 Chnaged
Lines 1498-1593 Added.

Thanks in advance

Thor R

#8 Updated by psychonic over 2 years ago

  • Tracker changed from Task to Bug

#9 Updated by Thor over 2 years ago

Also available in: Atom PDF